Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"
Date	2016-01-25 14:00 +0100
Message-ID	<qUOUr-40h-31@gated-at.bofh.it> (permalink)
References	<qU2G5-CL-7@gated-at.bofh.it> <qULtx-1Kq-25@gated-at.bofh.it> <qUOKK-3WU-5@gated-at.bofh.it> <qUOUq-40h-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-01-25 at 18:21 +0530, Sudip Mukherjee wrote:
> On Mon, Jan 25, 2016 at 04:47:26AM -0800, Joe Perches wrote:
> > On Mon, 2016-01-25 at 12:16 +0300, Dan Carpenter wrote:
> > > Ugh...  Checkpatch told us to introduce bugs...  :(  We almost certainly
> > > would have missed this bug in review, but it wasn't sent to the list so
> > > I guess we'll never know.
> > 
> > So when isn't usleep_range preferred over udelay?
> 
> inside a spin_lock or in some interrupt routine.

That's what timers-howto says and the checkpatch message
for this refers to it.

This message has been in checkpatch since 2010
commit 1a15a250862fda3fbdf8454cc7131e24de904e7c
Author: Patrick Pannuto <ppannuto@codeaurora.org>

Maybe the checkpatch message can have "when not atomic"
added or some such.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "Staging: panel: usleep_range is preferred over udelay" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-23 10:30 +0100
  Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-25 05:40 +0100
  Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-25 10:20 +0100
    Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-25 10:40 +0100
    Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-25 10:50 +0100
      Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-25 12:10 +0100
      Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-25 14:00 +0100
        Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay" Willy Tarreau <w@1wt.eu> - 2016-01-25 21:50 +0100
      Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay" "Huang\, Ying" <ying.huang@intel.com> - 2016-01-26 01:40 +0100
        Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-26 02:40 +0100
          Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay" "Huang\, Ying" <ying.huang@intel.com> - 2016-01-26 03:10 +0100
      Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-26 18:50 +0100
    Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Joe Perches <joe@perches.com> - 2016-01-25 13:50 +0100
      Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-25 14:00 +0100
        Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over  udelay" Joe Perches <joe@perches.com> - 2016-01-25 14:00 +0100

csiph-web