Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file
Date	2016-01-22 12:00 +0100
Message-ID	<qTHBE-2UG-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <qSDJL-7SY-3@gated-at.bofh.it> <qSEwa-8rZ-11@gated-at.bofh.it> <qSRa4-5e-89@gated-at.bofh.it> <qSUrf-2Au-11@gated-at.bofh.it> <qSWjo-3N7-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 20, 2016 at 04:24:36PM +0800, Peter Hung wrote:
> Hi Sudip,
> 
> Sudip Mukherjee 於 2016/1/20 下午 02:22 寫道:
> >On Wed, Jan 20, 2016 at 10:59:28AM +0800, Peter Hung wrote:
> 
> >But my personal opinion, if we move out the serial port related code
> >into a new driver (a new Kconfig symbol) userspace of many system will
> >break if this new symbol is not enabled by the distributions. But in the
> >way I have done the new symbol needs to be enabled only if the user
> >wants to use the GPIO capability. If that is not enabled GPIO cannot be
> >used but it will never break the serial port related code for them.
> >I think we should give a thought to that before splitting out the codes
> >from 8250_pci.
> 
> I agree with your opinion. I'm trying to implement GPIO with 2 ways,
> One is like yours, add platform_device with in 8250_pci.c and implement
> GPIOLIB platform driver with in 'driver/gpio", and the other is trying
> split out from 8250_pci.c to MFD.
> 
> In my personal opinion, the first method is less impact with compatible
> old system.

Looks like no one else is in support of our opinion. Fair enough, I will
split out the related code from 8250_pci and create the MFD driver this
weekend for my hardware.

regards
sudip

Thread

[PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Peter Hung <hpeter@gmail.com> - 2016-01-19 03:50 +0100
  [PATCH 1/3] serial: 8250_pci: Remove Fintek PCIE UART driver Peter Hung <hpeter@gmail.com> - 2016-01-19 03:50 +0100
  Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-01-19 05:00 +0100
    Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Peter Hung <hpeter@gmail.com> - 2016-01-19 09:50 +0100
      Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-19 10:40 +0100
      Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-19 13:40 +0100
        Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-19 14:30 +0100
          Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Peter Hung <hpeter@gmail.com> - 2016-01-20 04:00 +0100
            Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-20 07:30 +0100
              Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Peter Hung <hpeter@gmail.com> - 2016-01-20 09:30 +0100
                Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-22 12:00 +0100
                Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-22 14:50 +0100

csiph-web