Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing

From	Dave Hansen <dave.hansen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing
Date	2016-01-15 22:10 +0100
Message-ID	<qRjN8-39u-3@gated-at.bofh.it> (permalink)
References	<qO4Ui-7jF-21@gated-at.bofh.it> <qQ5VV-FV-47@gated-at.bofh.it> <qRjaq-2FM-1@gated-at.bofh.it> <qRjDs-2R7-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/15/2016 12:50 PM, Yu-cheng Yu wrote:
>> > 
>> > This could certainly be improved: we're iterating over the *whole*
>> > command line each time for each option unconditionally instead of
>> > iterating word by word and comparing it with all strings.
>> > 
>> > We'd need something like cmdline_for_each_word() or so, though...
>> > 
> That is a good point. I will work on it.

I really don't think we need to do this.  It's code that runs *ONCE* at
boot time.  Let's not work on optimizing it unless we have some acute need.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] x86/fpu: FPU init code bugfixes yu-cheng yu <yu-cheng.yu@intel.com> - 2016-01-06 23:40 +0100
  [PATCH 2/4] x86/fpu: Disable XGETBV1 when no XSAVE yu-cheng yu <yu-cheng.yu@intel.com> - 2016-01-06 23:40 +0100
    [tip:x86/asm] x86/fpu: Disable XGETBV1 when no XSAVE tip-bot for yu-cheng yu <tipbot@zytor.com> - 2016-01-12 13:10 +0100
  [PATCH 3/4] x86/fpu: Disable MPX when eagerfpu is off yu-cheng yu <yu-cheng.yu@intel.com> - 2016-01-06 23:40 +0100
    [tip:x86/asm] x86/fpu: Disable MPX when eagerfpu is off tip-bot for yu-cheng yu <tipbot@zytor.com> - 2016-01-12 13:10 +0100
  [PATCH 4/4] x86/fpu: Disable AVX when eagerfpu is off yu-cheng yu <yu-cheng.yu@intel.com> - 2016-01-06 23:40 +0100
    [tip:x86/asm] x86/fpu: Disable AVX when eagerfpu is off tip-bot for yu-cheng yu <tipbot@zytor.com> - 2016-01-12 13:10 +0100
  [PATCH 1/4] x86/fpu: Fix early fpu command-line parsing yu-cheng yu <yu-cheng.yu@intel.com> - 2016-01-06 23:40 +0100
    [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing tip-bot for yu-cheng yu <tipbot@zytor.com> - 2016-01-12 13:10 +0100
      Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing Borislav Petkov <bp@alien8.de> - 2016-01-15 21:30 +0100
        Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-01-15 22:00 +0100
          Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing Borislav Petkov <bp@alien8.de> - 2016-01-15 22:10 +0100
          Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing Dave Hansen <dave.hansen@linux.intel.com> - 2016-01-15 22:10 +0100

csiph-web