Re: [PATCH] net: macb: clear interrupts when disabling them

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: macb: clear interrupts when disabling them
Date	2016-01-15 20:50 +0100
Message-ID	<qRixI-2cl-11@gated-at.bofh.it> (permalink)
References	<qQX0f-3S8-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Nathan Sullivan <nathan.sullivan@ni.com>
Date: Thu, 14 Jan 2016 13:27:27 -0600

> Disabling interrupts with the IDR register does not stop the macb hardware
> from asserting its interrupt line if there are interrupts pending.  Always
> clear the interrupts using ISR, and be sure to write it on hardware that
> is not read-to-clear, like Zynq.  Not doing so will cause interrupts when
> the driver doesn't expect them.
> 
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: macb: clear interrupts when disabling them Nathan Sullivan <nathan.sullivan@ni.com> - 2016-01-14 21:50 +0100
  Re: [PATCH] net: macb: clear interrupts when disabling them Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-01-15 09:30 +0100
  Re: [PATCH] net: macb: clear interrupts when disabling them David Miller <davem@davemloft.net> - 2016-01-15 20:50 +0100

csiph-web