Re: [PATCH 2/2] powerpc/perf: Export Power8 generic and cache events to sysfs

From	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] powerpc/perf: Export Power8 generic and cache events to sysfs
Date	2016-01-15 20:50 +0100
Message-ID	<qRixI-2cl-13@gated-at.bofh.it> (permalink)
References	<qPTBo-vZ-17@gated-at.bofh.it> <qPTBo-vZ-27@gated-at.bofh.it> <qQOJk-6rt-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Madhavan Srinivasan [maddy@linux.vnet.ibm.com] wrote:
> > +enum {
> > +#include "power8-events-list.h"
> > +};
> >  
> 
> IIUC we dont use this enum as a index to
> some array, so can we do something like this?

Possibly, but its already a macro soup and we would add another
layer of indirection? I agree though that the #define and #undefs
are not intuitive. Since it is only a few entries for Power8, was
keeping it consistent with Power7.

Sukadev

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] powerpc/perf: Remove PME_ prefix for power7 events Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2016-01-12 00:00 +0100
  [PATCH 2/2] powerpc/perf: Export Power8 generic and cache events to sysfs Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2016-01-12 00:00 +0100
    Re: [PATCH 2/2] powerpc/perf: Export Power8 generic and cache events  to sysfs Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2016-01-14 13:00 +0100
      Re: [PATCH 2/2] powerpc/perf: Export Power8 generic and cache events  to sysfs Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2016-01-15 20:50 +0100

csiph-web