Re: [PATCH v2] net: preserve IP control block during GSO segmentation

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] net: preserve IP control block during GSO segmentation
Date	2016-01-15 20:40 +0100
Message-ID	<qRio2-26L-9@gated-at.bofh.it> (permalink)
References	<qOEl4-6Dm-21@gated-at.bofh.it> <qQAGl-54j-3@gated-at.bofh.it> <qQDbc-6Qp-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Florian Westphal <fw@strlen.de>
Date: Thu, 14 Jan 2016 00:36:28 +0100

> David Miller <davem@davemloft.net> wrote:
>> From: Konstantin Khlebnikov <koct9i@gmail.com>
>> Date: Fri, 08 Jan 2016 15:21:46 +0300
>> 
>> > Skb_gso_segment() uses skb control block during segmentation.
>> > This patch adds 32-bytes room for previous control block which
>> > will be copied into all resulting segments.
>> > 
>> > This patch fixes kernel crash during fragmenting forwarded packets.
>> > Fragmentation requires valid IP CB in skb for clearing ip options.
>> > Also patch removes custom save/restore in ovs code, now it's redundant.
>> > 
>> > Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
>> > Link: http://lkml.kernel.org/r/CALYGNiP-0MZ-FExV2HutTvE9U-QQtkKSoE--KN=JQE5STYsjAA@mail.gmail.com
>> 
>> If this works I definitely prefer this approach to the other patch
>> where the CB is copied back and forth.
> 
> I quite frankly don't care and just like you to apply one or the other;
> use coin toss if needed :-}

So I am going to apply this patch from Konstantin and queued it up for -stable.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: preserve IP control block during GSO segmentation Konstantin Khlebnikov <koct9i@gmail.com> - 2016-01-08 13:30 +0100
  Re: [PATCH v2] net: preserve IP control block during GSO  segmentation David Miller <davem@davemloft.net> - 2016-01-13 22:00 +0100
    Re: [PATCH v2] net: preserve IP control block during GSO segmentation Florian Westphal <fw@strlen.de> - 2016-01-14 00:40 +0100
      Re: [PATCH v2] net: preserve IP control block during GSO segmentation Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-01-15 00:30 +0100
      Re: [PATCH v2] net: preserve IP control block during GSO  segmentation David Miller <davem@davemloft.net> - 2016-01-15 20:40 +0100

csiph-web