Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1310405

Re: [PATCHv8 0/5] Driver for new "VMD" device

Show all headers | View raw

On Fri, Jan 15, 2016 at 12:19:38PM -0600, Bjorn Helgaas wrote:
> I applied these to pci/host-vmd with the changes below.  Most of them
> are cosmetic (rewrapping changelogs, fixing whitespace, etc.), but
> there are a few I'd like you to take a close look at:
> 
>   - Added VMD_CFGBAR and similar #defines
>   - Added vmd_cfg_addr() to factor out the addr computation and
>     validation
>   - Resource setup in vmd_enable_domain().  I suggested a temporary to
>     make the lines shorter.  I had the vmd->dev->resource[n] in mind,
>     but you added a temporary for vmd->resources[n].  Either way is
>     fine, but I liked the look of the v7 init, so I reverted to that,
>     with a temporary for vmd->dev->resource[n].
>   - Flags setup in vmd_enable_domain().  This was pretty confusing,
>     and I *think* what I did is equivalent, but you should verify.

Thanks for the cleanups. All the new changes look good to me, and I will
test your tree today to confirm no regressions.
 
> I'm still hoping to get this in during the merge window.

Thanks a bunch. This would be great timing to align the hardware
availability with various software and OEM vendors.
 
> If you want to test this, I recommend using my git branch
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/host-vmd
> instead of applying the patch below on top of your v8.  If you want
> to make changes, post an incremental patch based on that branch.

I'll give this a test today.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv8 0/5] Driver for new "VMD" device  Keith Busch <keith.busch@intel.com> - 2016-01-12 21:20 +0100
  [PATCHv8 1/5] msi: Relax msi_domain_alloc() to support parentless MSI irqdomains Keith Busch <keith.busch@intel.com> - 2016-01-12 21:20 +0100
  [PATCHv8 4/5] PCI/AER: Use 32 bit int type domains Keith Busch <keith.busch@intel.com> - 2016-01-12 21:20 +0100
  [PATCHv8 5/5] x86/PCI: Initial commit for new VMD device driver Keith Busch <keith.busch@intel.com> - 2016-01-12 21:20 +0100
  [PATCHv8 2/5] x86/IRQ: Export IRQ domain function for module use Keith Busch <keith.busch@intel.com> - 2016-01-12 21:20 +0100
  [PATCHv8 3/5] x86/PCI: Allow PCI domain specific dma ops Keith Busch <keith.busch@intel.com> - 2016-01-12 21:20 +0100
  Re: [PATCHv8 0/5] Driver for new "VMD" device Bjorn Helgaas <helgaas@kernel.org> - 2016-01-15 19:20 +0100
    Re: [PATCHv8 0/5] Driver for new "VMD" device "Veal, Bryan E." <bryan.e.veal@intel.com> - 2016-01-15 20:40 +0100
      Re: [PATCHv8 0/5] Driver for new "VMD" device Bjorn Helgaas <helgaas@kernel.org> - 2016-01-15 22:50 +0100
        Re: [PATCHv8 0/5] Driver for new "VMD" device "Veal, Bryan E." <bryan.e.veal@intel.com> - 2016-01-16 23:30 +0100
          Re: [PATCHv8 0/5] Driver for new "VMD" device Bjorn Helgaas <helgaas@kernel.org> - 2016-01-20 23:30 +0100
    Re: [PATCHv8 0/5] Driver for new "VMD" device Keith Busch <keith.busch@intel.com> - 2016-01-15 20:40 +0100
    Re: [PATCHv8 0/5] Driver for new "VMD" device Thomas Gleixner <tglx@linutronix.de> - 2016-01-15 20:50 +0100
      Re: [PATCHv8 0/5] Driver for new "VMD" device Bjorn Helgaas <bhelgaas@google.com> - 2016-01-15 21:10 +0100
        Re: [PATCHv8 0/5] Driver for new "VMD" device Thomas Gleixner <tglx@linutronix.de> - 2016-01-15 21:20 +0100
    RE: [PATCHv8 0/5] Driver for new "VMD" device "Derrick, Jonathan" <jonathan.derrick@intel.com> - 2016-01-15 20:50 +0100
      Re: [PATCHv8 0/5] Driver for new "VMD" device Keith Busch <keith.busch@intel.com> - 2016-01-15 21:00 +0100
        Re: [PATCHv8 0/5] Driver for new "VMD" device Jon Derrick <jonathan.derrick@intel.com> - 2016-01-15 21:10 +0100
      Re: [PATCHv8 0/5] Driver for new "VMD" device Bjorn Helgaas <helgaas@kernel.org> - 2016-01-15 23:10 +0100
        Re: [PATCHv8 0/5] Driver for new "VMD" device Keith Busch <keith.busch@intel.com> - 2016-01-19 16:40 +0100
          Re: [PATCHv8 0/5] Driver for new "VMD" device Christoph Hellwig <hch@infradead.org> - 2016-01-19 17:10 +0100
            Re: [PATCHv8 0/5] Driver for new "VMD" device Keith Busch <keith.busch@intel.com> - 2016-01-19 17:40 +0100
              Re: [PATCHv8 0/5] Driver for new "VMD" device "Veal, Bryan E." <bryan.e.veal@intel.com> - 2016-01-19 23:10 +0100
            Re: [PATCHv8 0/5] Driver for new "VMD" device Bjorn Helgaas <helgaas@kernel.org> - 2016-01-20 21:50 +0100
              Re: [PATCHv8 0/5] Driver for new "VMD" device Christoph Hellwig <hch@infradead.org> - 2016-01-26 17:50 +0100
                Re: [PATCHv8 0/5] Driver for new "VMD" device "Veal, Bryan E." <bryan.e.veal@intel.com> - 2016-01-26 19:30 +0100
  Re: [PATCHv8 0/5] Driver for new "VMD" device Christoph Hellwig <hch@infradead.org> - 2016-01-17 19:00 +0100

csiph-web