Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308809

Re: [PATCH v2] net: preserve IP control block during GSO segmentation

Show all headers | View raw

From: Konstantin Khlebnikov <koct9i@gmail.com>
Date: Fri, 08 Jan 2016 15:21:46 +0300

> Skb_gso_segment() uses skb control block during segmentation.
> This patch adds 32-bytes room for previous control block which
> will be copied into all resulting segments.
> 
> This patch fixes kernel crash during fragmenting forwarded packets.
> Fragmentation requires valid IP CB in skb for clearing ip options.
> Also patch removes custom save/restore in ovs code, now it's redundant.
> 
> Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
> Link: http://lkml.kernel.org/r/CALYGNiP-0MZ-FExV2HutTvE9U-QQtkKSoE--KN=JQE5STYsjAA@mail.gmail.com

If this works I definitely prefer this approach to the other patch
where the CB is copied back and forth.

Any other reviewers?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] net: preserve IP control block during GSO segmentation Konstantin Khlebnikov <koct9i@gmail.com> - 2016-01-08 13:30 +0100
  Re: [PATCH v2] net: preserve IP control block during GSO  segmentation David Miller <davem@davemloft.net> - 2016-01-13 22:00 +0100
    Re: [PATCH v2] net: preserve IP control block during GSO segmentation Florian Westphal <fw@strlen.de> - 2016-01-14 00:40 +0100
      Re: [PATCH v2] net: preserve IP control block during GSO segmentation Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-01-15 00:30 +0100

csiph-web