Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308194

Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024

Show all headers | View raw

On Wednesday 13 January 2016 06:17 AM, Krzysztof Kozlowski wrote:
> On 12.01.2016 18:17, Laxman Dewangan wrote:

>> +	}
>> +	dev_dbg(chip->dev, "NVERC = 0x%02x\n", val);
>> +	for (i = 0; i < 8; ++i) {
>> +		if (val & BIT(i))
>> +			dev_info(chip->dev, "NVERC: %s\n", max77620_nverc[i]);
> You are still printing two dev_info (OTP, ES) and here NVERC (probably
> one?). This will be printed on each boot, over and over, till the user
> will learn it and will remember it forever :).
>
>  From my point of view: one dev_info for one probed device.
>
> I don't know if others agree with that, though. What's your opinion Lee?

OK, I make single line print for OTP and ES version.
I remove the NVREC reading and printing as this is read on clear and 
better to move on uboot for this prints.


>
>
> +
> +	ret = regmap_add_irq_chip(chip->rmap[MAX77620_PWR_SLAVE],
> +		chip->chip_irq, IRQF_ONESHOT | IRQF_SHARED, chip->irq_base,
> Why do you need IRQF_SHARED?

In one of my design,  I have three PMICs, one MAX77620, two MAX77621. 
MAX77621 alert an MAX77620 interrupt line is tied and going to single 
interrupt of SoC.

To register same interrupt from all driver, I made it SHARED.

This is per discussion on the other patch
regulator: max8973: add support for junction thermal warning


>> +		&max77620_top_irq_chip, &chip->top_irq_data);
> More tabs needed for indentation of arguments.
>
> Actually the alignment of arguments here is mixed. Sometimes arguments
> are aligned with opening parenthesis, mostly not. Can you make it
> consistent - always aligned?


In my 3rd patch, I tried to align it little more where is possible. But 
I feel that all these indenting is more over individual choice. Example, 
I added one more indent in below example to look better.


         ret = max77620_reg_update(chip->dev, MAX77620_PWR_SLAVE,
-               MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0,
-               MAX77620_ONOFFCNFG2_WK_EN0);
+                       MAX77620_REG_ONOFFCNFG2, MAX77620_ONOFFCNFG2_WK_EN0,
+                       MAX77620_ONOFFCNFG2_WK_EN0);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/6] Add support for MAXIM MAX77620/MAX20024 PMIC Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 10:40 +0100
  [PATCH V2 4/6] gpio: max77620: add gpio driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 10:40 +0100
  [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-12 10:40 +0100
    Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 01:10 +0100
      Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 05:20 +0100
        Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 05:30 +0100
          Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 05:40 +0100
            Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 16:20 +0100
              Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-14 02:00 +0100
                Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-14 02:30 +0100
                Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-14 13:10 +0100
                Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Javier Martinez Canillas <javier@dowhile0.org> - 2016-01-15 03:00 +0100
                Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx  series RTC IP Mark Brown <broonie@kernel.org> - 2016-01-14 15:30 +0100
  Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-13 01:50 +0100
    Re: [PATCH V2 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-13 10:20 +0100
      Re: [PATCH V2 2/6] mfd: max77620: add core driver for  MAX77620/MAX20024 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-13 11:20 +0100

csiph-web