Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1308247

Re: [PATCH] gpiolib: fix chip order in gpio list

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] gpiolib: fix chip order in gpio list
Date Wed, 13 Jan 2016 11:20:01 +0100
Message-ID <qQqGZ-6FS-5@gated-at.bofh.it> (permalink)
References <qOqLa-5yd-29@gated-at.bofh.it>
X-Original-To Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>, Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pAZcjYq2ghCm1/+WsC5C+0dp7K9YxaOQOpAAK7uygn8=; b=N2zG+nrhKRarSRoUZsPauo98hRx7yoSIaY1nlqumHnaWCHBiddOPNVv16/zVokHIj7 9mpBcD6y0VcRvibRoLOvWb/2an1BkrshjmblkqUmA5bZh5JDqwdxP568ibpal7ntKKCj MR6j1H1JoBS8MEh0kuLaTYI7T+FSTwNPhHWeo=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=pAZcjYq2ghCm1/+WsC5C+0dp7K9YxaOQOpAAK7uygn8=; b=IrvbTxuZZEt4sctT9PHbT3SiudUHFh/FooT7M5cnAbGLRNmvs1EWc9YLKl3fR4Vfds MYPeUoao4aIjZisLZS+kBruPoUsr4w+MR2NT1NyxvTZ6tkwSmJT5K/KQP1DHWXK4KXku 6j/2zGRqriFb9an7dimGo/9DW04zVzMA1McL8TWYFjhuNiPDFNXsp7Jb8j3vtAZKt7hm EyeiFPHudlaJUX5J5tcq+6IC1XPXvhG4LypxGNUq02uKzAP64Q2azvMQA4JMz8tOjyMI VqejRbBZ7Yke3H4eAUJI2vynbPIiJTCs0iOgcEvibpLxgHCV94yBZ1A8qOky11VjIgy8 NOLw==
X-Gm-Message-State ALoCoQl3EZmUcfdbgoj+IatVYzyfxkqZmkInqu9eaRmVD+B30EVzvBLq1lCWYmYYfjOeMcxHNB5NteZF63L67/85U1S/1eT3URI+uTd3HHhATytnN48oocY=
MIME-Version 1.0
X-Received by 10.202.102.102 with SMTP id a99mr99795265oic.113.1452679862824; Wed, 13 Jan 2016 02:11:02 -0800 (PST)
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 20
Organization linux.* mail to news gateway
X-Original-Cc Alexandre Courbot <gnurou@gmail.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, kernel <kernel@savoirfairelinux.com>
X-Original-Date Wed, 13 Jan 2016 11:11:02 +0100
X-Original-Message-ID <CACRpkdZb1wWy-19y9BX9T0xeKUfmC2ym-sd4JEoLqhqVeb6GFw@mail.gmail.com>
X-Original-References <1452203205-4660-1-git-send-email-julien.grossholtz@savoirfairelinux.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1308247

Show key headers only | View raw


On Thu, Jan 7, 2016 at 10:46 PM, Julien Grossholtz
<julien.grossholtz@savoirfairelinux.com> wrote:

> In some situations the gpio_list order is not correct.
> As a consequence gpiochip_find_base returns the same
> base number twice. This happens when a first ship is added
> with manual base number, then other ships are added using
> automatic base number.
>
> To prevent this behaviour, this patch add the new ship after
> the last element of the gpio list.
>
> Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>

Patch looks correct to me so applied.

Bamvor: please comment if you see some problems.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] gpiolib: fix chip order in gpio list Julien Grossholtz <julien.grossholtz@savoirfairelinux.com> - 2016-01-07 23:00 +0100
  Re: [PATCH] gpiolib: fix chip order in gpio list Linus Walleij <linus.walleij@linaro.org> - 2016-01-13 11:20 +0100
    Re: [PATCH] gpiolib: fix chip order in gpio list Bamvor Zhang Jian <bamvor.zhangjian@linaro.org> - 2016-01-14 08:10 +0100

csiph-web