Re: [PATCH] gpiolib: fix chip order in gpio list

From	Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpiolib: fix chip order in gpio list
Date	2016-01-14 08:10 +0100
Message-ID	<qQKcF-3zU-1@gated-at.bofh.it> (permalink)
References	<qOqLa-5yd-29@gated-at.bofh.it> <qQqGZ-6FS-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/13/2016 06:11 PM, Linus Walleij wrote:
> On Thu, Jan 7, 2016 at 10:46 PM, Julien Grossholtz
> <julien.grossholtz@savoirfairelinux.com> wrote:
>
>> In some situations the gpio_list order is not correct.
>> As a consequence gpiochip_find_base returns the same
>> base number twice. This happens when a first ship is added
>> with manual base number, then other ships are added using
>> automatic base number.
>>
>> To prevent this behaviour, this patch add the new ship after
s/ship/chip
>> the last element of the gpio list.
>>
>> Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
>
> Patch looks correct to me so applied.
>
> Bamvor: please comment if you see some problems.
Nope, it could pass all the testcases I wrote.

Regards

Bamvor
>
> Yours,
> Linus Walleij
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpiolib: fix chip order in gpio list Julien Grossholtz <julien.grossholtz@savoirfairelinux.com> - 2016-01-07 23:00 +0100
  Re: [PATCH] gpiolib: fix chip order in gpio list Linus Walleij <linus.walleij@linaro.org> - 2016-01-13 11:20 +0100
    Re: [PATCH] gpiolib: fix chip order in gpio list Bamvor Zhang Jian <bamvor.zhangjian@linaro.org> - 2016-01-14 08:10 +0100

csiph-web