Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308202

Re: [PATCH -next] gpio: mm-lantiq: Do not use gpiochip_get_data() in ltq_mm_save_regs()

Show all headers | View raw

On Thu, Jan 7, 2016 at 5:24 PM, Guenter Roeck <linux@roeck-us.net> wrote:

> Commit 6aa7dbfa2877 ("gpio: mm-lantiq: use gpiochip data pointer") replaces
> the use of container_of() with gpiochip_get_data(). However, the data
> pointer is not yet set by the time the save_regs function is called.
>
> Fixes: 6aa7dbfa2877 ("gpio: mm-lantiq: use gpiochip data pointer")
> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> Cc: John Crispin <blogic@openwrt.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Patch applied.

> It might make sense to merge this patch into the patch causing the problem.

Nah, don't wanna rebase. Plus people should see all mistakes I make...

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] gpio: mm-lantiq: Do not use gpiochip_get_data() in ltq_mm_save_regs() Guenter Roeck <linux@roeck-us.net> - 2016-01-07 17:30 +0100
  Re: [PATCH -next] gpio: mm-lantiq: Do not use gpiochip_get_data() in ltq_mm_save_regs() Linus Walleij <linus.walleij@linaro.org> - 2016-01-13 10:30 +0100

csiph-web