Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305143

Re: [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s for kylin board

Show all headers | View raw

Hi Caesar,

Am Donnerstag, 7. Januar 2016, 16:25:46 schrieb Caesar Wang:
> The sysclk seems be incorrect since we use the simple card for kylin
> board.
> 
> The simple card call:
> 
> asoc_simple_card_probe ->
>  asoc_simple_card_dai_link_of ->
>   asoc_simple_card_sub_parse_of ->
> ...
> clk = of_clk_get(args.np, 0);
> if (!IS_ERR(clk))
> dai->sysclk = clk_get_rate(clk);
> 
> The sysclk come from the first clock, then first clock is hclk_i2s
> in i2s for rk3036 dtsi.
> So, we can override the clocks to fit the simple card in here.

It's not that effective, doing that change on a per-board level - as it
would possibly need to be repeated for future boards.
The i2s driver doesn't care, as it uses named clocks, so I instead did
the swap in the rk3036.dtsi for all boards. Can you check if that is ok
for you or if I did overlook something?


Thanks
Heiko

------- 8< -------
Subject: [PATCH] ARM: dts: rockchip: swap i2s clock ordering on rk3036

For sound setups using the simple-card mechanism, the main clock
(sysclk) is expected to be the first element. For the i2s-driver
itself it doesn't matter, as it uses named clocks, so we can just
swap them.

Reported-by: Caesar Wang <wxt@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm/boot/dts/rk3036.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
index 8f1bb0f..ee457a2 100644
--- a/arch/arm/boot/dts/rk3036.dtsi
+++ b/arch/arm/boot/dts/rk3036.dtsi
@@ -241,8 +241,8 @@
 		interrupts = <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
 		#address-cells = <1>;
 		#size-cells = <0>;
-		clock-names = "i2s_hclk", "i2s_clk";
-		clocks = <&cru HCLK_I2S>, <&cru SCLK_I2S>;
+		clock-names = "i2s_clk", "i2s_hclk";
+		clocks = <&cru SCLK_I2S>, <&cru HCLK_I2S>;
 		dmas = <&pdma 0>, <&pdma 1>;
 		dma-names = "tx", "rx";
 		pinctrl-names = "default";
-- 
2.6.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/12] Add the family patches to support for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 01/12] ARM: dts: rockchip: set the pinctrl default setting for rk3036 i2s Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 01/12] ARM: dts: rockchip: set the pinctrl default setting for rk3036 i2s Heiko Stuebner <heiko@sntech.de> - 2016-01-09 03:20 +0100
  [PATCH v2 09/12] ARM: dts: rockchip: enable the uart0 for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 11/12] ARM: dts: rockchip: add the lcdc and hdmi node for rk3036 Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing through DT Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing  through DT Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-08 13:30 +0100
      Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing through DT Heiko Stuebner <heiko@sntech.de> - 2016-01-09 03:50 +0100
        Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing  through DT Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-11 17:10 +0100
          Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing  through DT Caesar Wang <caesar.upstream@gmail.com> - 2016-01-15 10:20 +0100
  [PATCH v2 12/12] ARM: dts: Add pl330-broken-no-flushp quirk for rk3036 SoCs Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s for kylin board Heiko Stuebner <heiko@sntech.de> - 2016-01-09 03:40 +0100
      Re: [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s  for kylin board Caesar Wang <caesar.upstream@gmail.com> - 2016-01-11 14:40 +0100
  [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Heiko Stuebner <heiko@sntech.de> - 2016-01-07 11:10 +0100
      Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the  CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang <caesar.upstream@gmail.com> - 2016-01-08 10:30 +0100
        Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Heiko Stuebner <heiko@sntech.de> - 2016-01-08 10:50 +0100
          Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the  CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang <caesar.upstream@gmail.com> - 2016-01-13 09:20 +0100
  [PATCH v2 05/12] mmc: pwrseq: Document optional exteral vcc for the simple power sequence Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
    Re: [PATCH v2 05/12] mmc: pwrseq: Document optional exteral vcc for  the simple power sequence Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-08 13:20 +0100
  [PATCH v2 07/12] ARM: dts: rockchip: enable the high speed on sdio for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  [PATCH v2 10/12] ARM: dts: rockchip: add the sdmmc for kylin board Caesar Wang <wxt@rock-chips.com> - 2016-01-07 09:30 +0100
  Re: [PATCH v2 00/12] Add the family patches to support for kylin board Heiko Stuebner <heiko@sntech.de> - 2016-01-07 11:50 +0100

csiph-web