Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

From	Timur Tabi <timur@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe
Date	2016-01-11 22:40 +0100
Message-ID	<qPSlX-84V-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <qISAq-2iG-3@gated-at.bofh.it> <qNmzU-1JR-15@gated-at.bofh.it> <qNvDb-84L-7@gated-at.bofh.it> <qNCEG-5ih-9@gated-at.bofh.it> <qNU8A-jS-67@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Graeme Gregory wrote:
>> >
>> >So with this patch, what is the difference between sbsa_uart_probe and
>> >pl011_probe?  Shouldn't the patch also remove sbsa_uart_probe?
>> >
> One is for amba_device and one is for platform_device and one maintainer
> indicated displeasure at platfrom device being in an AMBA driver.

Ok, I'm still a little confused, but it sounds to me like your patch 
should have also removed sbsa_uart_probe().

With your patches applied, under what circumstance would 
sbsa_uart_probe() still be called?  The amba-pl011.c driver already 
probes on ARMH0011, so shouldn't that be removed, to avoid a double probe?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Timur Tabi <timur@codeaurora.org> - 2016-01-05 00:20 +0100
  Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe G Gregory <graeme.gregory@linaro.org> - 2016-01-05 10:00 +0100
    Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Timur Tabi <timur@codeaurora.org> - 2016-01-05 17:30 +0100
      Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Graeme Gregory <gg@slimlogic.co.uk> - 2016-01-06 12:10 +0100
        Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Timur Tabi <timur@codeaurora.org> - 2016-01-11 22:40 +0100

csiph-web