Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301675

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe

Show all headers | View raw

G Gregory wrote:
>> >I'm confused by this patch.  We already have code like this in
>> >tty-next, in the form of sbsa_uart_probe():
>> >
>> >https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/tty/+/tty-next/drivers/tty/serial/amba-pl011.c#2553
>> >
> Because Russell expressed unhappiness at that code existing. So this
> is an alternative method to do same thing with ACPI.

FYI, this patch doesn't apply on tty-next as-is, so it would need to be 
updated anyway.  Then again, considering the latest drama with that 
driver, who knows what it will look like?

> If the "arm,sbsa-uart" id was added to drivers/of/platform.c as an
> AMBA id then the same could be done for DT as well.
>
> Ultimately this patch is optional depending on maintainers opinion!

So with this patch, what is the difference between sbsa_uart_probe and 
pl011_probe?  Shouldn't the patch also remove sbsa_uart_probe?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Timur Tabi <timur@codeaurora.org> - 2016-01-05 00:20 +0100
  Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe G Gregory <graeme.gregory@linaro.org> - 2016-01-05 10:00 +0100
    Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Timur Tabi <timur@codeaurora.org> - 2016-01-05 17:30 +0100
      Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Graeme Gregory <gg@slimlogic.co.uk> - 2016-01-06 12:10 +0100
        Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Timur Tabi <timur@codeaurora.org> - 2016-01-11 22:40 +0100

csiph-web