Re: [GIT PULL] please pull one bug fix for v4.4

From	Jeff Merkey <linux.mdb@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] please pull one bug fix for v4.4
Date	2016-01-11 22:30 +0100
Message-ID	<qPScj-817-17@gated-at.bofh.it> (permalink)
References	<qFoIx-6Ft-7@gated-at.bofh.it> <qFq7D-7FC-3@gated-at.bofh.it> <qFrGp-j0-3@gated-at.bofh.it> <qPRzA-7vv-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 1/11/16, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> The merge window is open, so I started looking at this that I had
> ignored as being too late last time..
>
> On Sun, Dec 13, 2015 at 7:02 PM, Jeff Merkey <linux.mdb@gmail.com> wrote:
>> Patch address with email included:
>>
>> https://github.com/jeffmerkey/linux/commit/e1d3c76814c839a835286843f0bca33b0c5d0dd8.patch
>
> So at a minimum, I'd like a sign-off for the patch. But also, can you
> describe how to actually trigger the problem? Is this actually
> triggerable without an ICE?
>
>                 Linus
>

Hi Linus,

It is triggerable without an ice, any module can call set_debugreg dr7
and trigger it, and some do, and I suspect a lot of cases where folks
see hard hangs are related to this issue if some program happens to
stuff bogus data into dr6 -- most folks just don't know this is what
causes it.

That being said,  it seems to require an ICE of some sort fiddling
with the debug registers to cause it, though there are places in the
code I based on what I reviewed where someone running GDB from
userspace could trigger it because thread.debugreg6 gets whacked.
Not all of the code paths clear the trap flag in debugreg6 after a
trap occurs and this bit seems to get recycled.

I will send you an updated pull location properly signed off.

Jeff

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [GIT PULL] please pull one bug fix for v4.4 Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-11 21:50 +0100
  Re: [GIT PULL] please pull one bug fix for v4.4 Thomas Gleixner <tglx@linutronix.de> - 2016-01-11 22:00 +0100
    Re: [GIT PULL] please pull one bug fix for v4.4 Jeff Merkey <linux.mdb@gmail.com> - 2016-01-11 22:40 +0100
  Re: [GIT PULL] please pull one bug fix for v4.4 Jeff Merkey <linux.mdb@gmail.com> - 2016-01-11 22:30 +0100

csiph-web