Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301379

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

Show all headers | View raw

Hi Markus,

On Tue, Jan 5, 2016 at 7:29 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>> That said, if you figure out some change that produces significant
>> reductions in code or binary size on multiple architectures without
>> making things more complicated, less readable or making the code or
>> binary size larger, then by all means propose it.
>
> Are you looking also for "a proof" that such changes are worthwhile?

It'd be better than "I think doing things this way is better", which
is the hallmark of most of your patch sets. (Admittedly not this one,
but this one is where the discussion is now, so that's where we're
discussing it.)

>> "This makes things smaller" carries much more weight than
>> "I think this is better".
>
> Can the discussed implementation of a function like "rsi_send_mgmt_pkt"
> become a bit smaller by the deletion of extra variable initialisations

I'm talking in general.

In this case you're asking people to review a patch which requires a
lot of careful review for a fairly minor improvement. I must also note
that you haven't CC'd the people who wrote this driver, so it's
possible that the only people who have reviewed it aren't experts in
the code.

The patches you sent recently which moved labels into if statements
were a clear case of "I think this is better" where any actual benefit
from the changes was eclipsed by the style and readability issues they
introduced.

>> Almost all of the changes you've proposed that have seen any
>> discussion whatsoever fall into the latter category.
>
> Thanks for your interesting feedback.

No problem.

> Can a further constructive dialogue evolve from the presented information?

Part of the issue here is that you don't seem to be listening to the
discussion of your patches, or if you are, you're not significantly
changing your approach or attitude in response.

Every time you send a set of patches, there are legitimate issues
which people raise, and every time they are discussed, you assert that
your patches improve things and seem to ignore the concerns people
raise.

I've seen this same pattern of discussion here with these patches,
with your patches to move labels into if statements, with the patches
you sent late June last year, your patches to remove conditions before
kfree() and friends, etc.

You need to change you attitude: just because you can see some benefit
from your patches doesn't mean others do and it doesn't mean that
they're willing to accept them.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 15:50 +0100
  net-rsi: Reconsider usage of variable "vap_id" in rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 16:20 +0100
  Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 10:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 10:40 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 11:50 +0100
      Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 12:50 +0100
        Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 13:40 +0100
          Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Julian Calaby <julian.calaby@gmail.com> - 2016-01-05 01:00 +0100
            Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-05 09:40 +0100
              Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Julian Calaby <julian.calaby@gmail.com> - 2016-01-05 10:50 +0100
                Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-05 17:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Bjørn Mork <bjorn@mork.no> - 2016-01-04 14:20 +0100
      Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 15:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations  in rsi_send_mgmt_pkt() David Miller <davem@davemloft.net> - 2016-01-04 18:20 +0100

csiph-web