Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1301680

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

Show all headers | View raw

> Every time you send a set of patches,

I suggested some updates for Linux source files since October 2014.


> there are legitimate issues which people raise,

There was usual feedback.


> and every time they are discussed,

The discussion results were mixed between acceptance
and usual disagreement.


> you assert that your patches improve things

I guess that should be the default intention of every patch, shouldn't it?


> and seem to ignore the concerns people raise.

I hope not. - But I can imagine that you might understand some responses
from contributors in this way.
Are you waiting for another clarification on a specific issue?


> I've seen this same pattern of discussion here with these patches,
> with your patches to move labels into if statements, with the patches
> you sent late June last year, your patches to remove conditions before
> kfree() and friends, etc.

It seems that communication difficulties come partly from the fact
that I chose search patterns from static source code analysis so far
which belong to an error category that gets a lower priority.


> You need to change you attitude: just because you can see some benefit
> from your patches doesn't mean others do and it doesn't mean that
> they're willing to accept them.

I understand your advice.

Further update suggestions with higher importance might follow for various
software areas in the future.

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 15:50 +0100
  net-rsi: Reconsider usage of variable "vap_id" in rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 16:20 +0100
  Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 10:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 10:40 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 11:50 +0100
      Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 12:50 +0100
        Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 13:40 +0100
          Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Julian Calaby <julian.calaby@gmail.com> - 2016-01-05 01:00 +0100
            Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-05 09:40 +0100
              Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Julian Calaby <julian.calaby@gmail.com> - 2016-01-05 10:50 +0100
                Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-05 17:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Bjørn Mork <bjorn@mork.no> - 2016-01-04 14:20 +0100
      Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 15:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations  in rsi_send_mgmt_pkt() David Miller <davem@davemloft.net> - 2016-01-04 18:20 +0100

csiph-web