Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()
Date	2016-01-04 12:50 +0100
Message-ID	<qNbOa-2VD-5@gated-at.bofh.it> (permalink)
References	<qEuGl-43C-5@gated-at.bofh.it> <qMvFg-RW-3@gated-at.bofh.it> <qMvFg-RW-15@gated-at.bofh.it> <qN9CF-1zZ-1@gated-at.bofh.it> <qNaS6-2gZ-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 04, 2016 at 11:44:15AM +0100, SF Markus Elfring wrote:
> > Please stop sending cleanup patches, Markus.  Just send fixes.
> 
> How often will source code clean-up fix something?
> 
> 
> May I resend a consistent patch series for the source file
> "drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future?

If you were sending checkpatch.pl fixes that would be easier to deal
with but you are sending hundreds of "controversial" cleanups.  They are
controversial in the sense that they don't fix anything against official
kernel style and they go against the author's original intention.  I
tend to agree that useless initializers are bad and disable GCCs
uninitialized variable warnings but just because I agree with you
doesn't make it official kernel style.  It's slightly rude to go against
the author's intention.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 15:50 +0100
  net-rsi: Reconsider usage of variable "vap_id" in rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-02 16:20 +0100
  Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 10:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 10:40 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 11:50 +0100
      Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 12:50 +0100
        Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-04 13:40 +0100
          Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Julian Calaby <julian.calaby@gmail.com> - 2016-01-05 01:00 +0100
            Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-05 09:40 +0100
              Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Julian Calaby <julian.calaby@gmail.com> - 2016-01-05 10:50 +0100
                Re: rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-05 17:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Bjørn Mork <bjorn@mork.no> - 2016-01-04 14:20 +0100
      Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in  rsi_send_mgmt_pkt() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-04 15:30 +0100
    Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations  in rsi_send_mgmt_pkt() David Miller <davem@davemloft.net> - 2016-01-04 18:20 +0100

csiph-web