Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300089

Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition

From Pali Rohár <pali.rohar@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition
Date 2016-01-02 16:50 +0100
Message-ID <qMwBj-1tc-9@gated-at.bofh.it> (permalink)
References <qM5KO-1Gt-13@gated-at.bofh.it> <qM649-1Nv-3@gated-at.bofh.it> <qM6dP-1R8-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Friday 01 January 2016 12:33:03 Ivaylo Dimitrov wrote:
> Hi Pali,
> 
> On  1.01.2016 13:26, Pali Rohár wrote:
> > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote:
> >> All calls to isp1704_write() are using parameter sequence of
> >> isp1704_write(isp, reg, val) but the function is defined as
> >> isp1704_write(isp, val, reg). Fix isp1704_write function
> >> definition so that the driver to be functional.
> >> 
> >> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > 
> > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> > 
> > This problem is there since inclusion of driver itself. No idea why
> > that driver could work... I remember that it detected correctly
> > type of charger.
> > 
> > I will test this patch on real N900 HW in one or two weeks to check
> > how it behave after patching...
> 
> Well, I  tested in on real HW, wall charger as well as USB were
> correctly detected. No idea what else needs to be tested, but I guess
> if you guide me, I can test whatever is needed.
> 
> Ivo

I think nothing more is needed to test. But I want to see how driver 
behave with and without this patch.

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-01-01 12:10 +0100
  Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Pali Rohár <pali.rohar@gmail.com> - 2016-01-01 12:30 +0100
    Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write()  definition Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-01-01 12:40 +0100
      Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Pali Rohár <pali.rohar@gmail.com> - 2016-01-02 16:50 +0100
    Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Pali Rohár <pali.rohar@gmail.com> - 2016-01-09 23:50 +0100

csiph-web