Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition
Date	2016-01-09 23:50 +0100
Message-ID	<qPauD-3CC-29@gated-at.bofh.it> (permalink)
References	<qM5KO-1Gt-13@gated-at.bofh.it> <qM649-1Nv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Friday 01 January 2016 12:26:21 Pali Rohár wrote:
> On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote:
> > All calls to isp1704_write() are using parameter sequence of
> > isp1704_write(isp, reg, val) but the function is defined as
> > isp1704_write(isp, val, reg). Fix isp1704_write function definition
> > so that the driver to be functional.
> > 
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> 
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> 
> This problem is there since inclusion of driver itself. No idea why
> that driver could work... I remember that it detected correctly type
> of charger.
> 
> I will test this patch on real N900 HW in one or two weeks to check
> how it behave after patching...

Tested-by: Pali Rohár <pali.rohar@gmail.com>

Please send this patch to all stable kernels.

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Pali Rohár <pali.rohar@gmail.com> - 2016-01-09 23:50 +0100

csiph-web