Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299879

Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote:
> All calls to isp1704_write() are using parameter sequence of
> isp1704_write(isp, reg, val) but the function is defined as
> isp1704_write(isp, val, reg). Fix isp1704_write function definition
> so that the driver to be functional.
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>

Reviewed-by: Pali Rohár <pali.rohar@gmail.com>

This problem is there since inclusion of driver itself. No idea why that 
driver could work... I remember that it detected correctly type of 
charger.

I will test this patch on real N900 HW in one or two weeks to check how 
it behave after patching...

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-01-01 12:10 +0100
  Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Pali Rohár <pali.rohar@gmail.com> - 2016-01-01 12:30 +0100
    Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write()  definition Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-01-01 12:40 +0100
      Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Pali Rohár <pali.rohar@gmail.com> - 2016-01-02 16:50 +0100
    Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Pali Rohár <pali.rohar@gmail.com> - 2016-01-09 23:50 +0100

csiph-web