Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300387

Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS

Show all headers | View raw

On Mon, Jan 04, 2016 at 07:12:33AM +1100, Dave Chinner wrote:

> That'd be a nice start, though it doesn't address callers of
> vm_map_ram() which also has hard-coded GFP_KERNEL allocation masks
> for various allocations.

... all 3 of them, that is - XFS, android/ion/ion_heap.c and
v4l2-core.  5 call sites total.  Adding a gfp_t argument to those
shouldn't be an issue...

BTW, far scarier one is not GFP_NOFS or GFP_IO - there's a weird
caller passing GFP_ATOMIC to __vmalloc(), for no reason I can guess.

_That_ really couldn't be handled without passing gfp_t to page allocation
primitives, but I very much doubt that it's needed there at all; it's in
alloc_large_system_hash() and I really cannot imagine a situation when
it would be used in e.g. a nonblocking context.

Folks, what is that one for?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

__vmalloc() vs. GFP_NOIO/GFP_NOFS Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-03 08:20 +0100
  Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-03 18:00 +0100
  Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Dave Chinner <david@fromorbit.com> - 2016-01-03 21:20 +0100
    Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-03 21:40 +0100
      Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Michal Hocko <mhocko@kernel.org> - 2016-01-05 16:40 +0100
  Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-01-04 14:50 +0100

csiph-web