Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300752

Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS

Show all headers | View raw

On 2016/01/03 16:12, Al Viro wrote:
> Those, AFAICS, are such callers with GFP_NOIO; however, there's a shitload
> of GFP_NOFS ones.  XFS uses memalloc_noio_save(), but a _lot_ of other
> callers do not.  For example, all call chains leading to ceph_kvmalloc()
> pass GFP_NOFS and none of them is under memalloc_noio_save().  The same
> goes for GFS2 __vmalloc() callers, etc.  Again, quite a few of those probably
> do not need GFP_NOFS at all, but those that do would appear to have
> hard-to-trigger deadlocks.
> 
> Why do we do that in callers, though?  I.e. why not do something like this:

This problem is not specific to vmalloc(). It is difficult for
non-fs developers to determine whether they need to use GFP_NOFS than
GFP_KERNEL in their code. Can't we annotate GFP_NOFS/GFP_NOIO sections like
http://marc.info/?l=linux-mm&m=142797559822655 ?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

__vmalloc() vs. GFP_NOIO/GFP_NOFS Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-03 08:20 +0100
  Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-03 18:00 +0100
  Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Dave Chinner <david@fromorbit.com> - 2016-01-03 21:20 +0100
    Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-03 21:40 +0100
      Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Michal Hocko <mhocko@kernel.org> - 2016-01-05 16:40 +0100
  Re: __vmalloc() vs. GFP_NOIO/GFP_NOFS Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-01-04 14:50 +0100

csiph-web