Re: [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime
Date	2015-12-23 01:40 +0100
Message-ID	<qIFDc-2Co-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <qHToS-5QV-17@gated-at.bofh.it> <qIcBb-11j-1@gated-at.bofh.it> <qIidz-4AG-5@gated-at.bofh.it> <qIkfn-5NU-3@gated-at.bofh.it> <qIFDc-2Co-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/22/2015 02:05 PM, Tomas Winkler wrote:

>
>  > Do you see a situation where holding the lock between calls into the driver
>  > might be a problem ?
>
> I don't think u are holding the lock now in watchdog_unregister when WDOG_UNREGISTERED was dropped.

the lock is held while clearing the pointers:

	mutex_lock(&wd_data->lock);
         wd_data->wdd = NULL;
         wdd->wd_data = NULL;
         mutex_unlock(&wd_data->lock);

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] watchdog: Replace driver based refcounting Guenter Roeck <linux@roeck-us.net> - 2015-12-20 22:10 +0100
  [PATCH 5/5] hwmon: (sch56xx) Drop watchdog driver data reference count callbacks Guenter Roeck <linux@roeck-us.net> - 2015-12-20 22:10 +0100
    Re: [PATCH 5/5] hwmon: (sch56xx) Drop watchdog driver data reference  count callbacks Hans de Goede <hdegoede@redhat.com> - 2015-12-21 11:40 +0100
      Re: [PATCH 5/5] hwmon: (sch56xx) Drop watchdog driver data reference  count callbacks Guenter Roeck <linux@roeck-us.net> - 2015-12-21 14:30 +0100
  [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-20 22:10 +0100
    Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Damien Riegel <damien.riegel@savoirfairelinux.com> - 2015-12-21 18:40 +0100
      Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-22 02:20 +0100
        Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Damien Riegel <damien.riegel@savoirfairelinux.com> - 2015-12-22 17:10 +0100
          Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-22 17:30 +0100
            Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Damien Riegel <damien.riegel@savoirfairelinux.com> - 2015-12-22 20:30 +0100
              Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-22 20:40 +0100
      Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-22 02:50 +0100
        Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-23 01:40 +0100

csiph-web