Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1297175
| From | Valdis Kletnieks <Valdis.Kletnieks@vt.edu> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 2/6] drivers/staging/lustre: Fix set-but-unused whinge. |
| Date | 2015-12-23 01:40 +0100 |
| Message-ID | <qIFDc-2Co-7@gated-at.bofh.it> (permalink) |
| References | <qIFDb-2Co-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
drivers/staging/lustre/lustre/fid/lproc_fid.c: In function 'ldebugfs_fid_write_common': drivers/staging/lustre/lustre/fid/lproc_fid.c:67:6: warning: variable 'rc' set but not used [-Wunused-but-set-variable] int rc; We fix it by *using* the return code to help bulletproof it. It says it's test code - it should be *more* bulletproof than production, not less. Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu> --- drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c b/drivers/staging/lustre/lustre/fid/lproc_fid.c index ce90c1c54a63..eff011f30fa5 100644 --- a/drivers/staging/lustre/lustre/fid/lproc_fid.c +++ b/drivers/staging/lustre/lustre/fid/lproc_fid.c @@ -85,6 +85,8 @@ ldebugfs_fid_write_common(const char __user *buffer, size_t count, rc = sscanf(kernbuf, "[%llx - %llx]\n", (unsigned long long *)&tmp.lsr_start, (unsigned long long *)&tmp.lsr_end); + if (rc != 2) + return -EINVAL; if (!range_is_sane(&tmp) || range_is_zero(&tmp) || tmp.lsr_start < range->lsr_start || tmp.lsr_end > range->lsr_end) return -EINVAL; -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/6] Patch series to make lustre safe(r) for W=1 compiles Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-23 01:40 +0100 [PATCH v3 6/6] drivers/staging/lustre: Nuke another unsigned >= 0 assert Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-23 01:40 +0100 [PATCH v3 5/6] drivers/staging/lustre: Nuke an unsigned >= 0 assert Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-23 01:40 +0100 [PATCH v3 2/6] drivers/staging/lustre: Fix set-but-unused whinge. Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-23 01:40 +0100 [PATCH v3 3/6] drivers/staging/lustre: Clean up another C warnining: set but not used Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-23 01:40 +0100 [PATCH v3 4/6] drivers/staging/lustre: Fix another C compiler whine: set but not used Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-23 01:40 +0100 [PATCH v3 1/6] drivers/staging/lustre: Silence warning about 'inline' Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2015-12-23 01:40 +0100
csiph-web