Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1295690

[PATCH 0/5] watchdog: Replace driver based refcounting

Show all headers | View raw

All variables required by the watchdog core to manage a watchdog are
currently stored in struct watchdog_device. The lifetime of those
variables is determined by the watchdog driver. However, the lifetime
of variables used by the watchdog core differs from the lifetime of
struct watchdog_device. To remedy this situation, watchdog drivers
can implement ref and unref callbacks, to be used by the watchdog
core to lock struct watchdog_device in memory. This mechanism was
introduced with commit e907df327252 ("watchdog: Add support for
dynamically allocated watchdog_device structs").

While this solves the immediate problem, it depends on watchdog drivers
to actually implement the ref/unref callbacks. This is error prone,
often not implemented in the first place, or not implemented correctly.

To solve the problem without requiring driver support, split the variables
in struct watchdog_device into two data structures - one for variables
associated with the watchdog driver, one for variables associated with
the watchdog core. With this approach, the watchdog core can keep track
of the variables it uses and no longer depends on ref/unref callbacks
in the driver. As a side effect, some of the variables originally in struct
watchdog_driver are now private to the watchdog core and no longer visible
in watchdog drivers.

The 'ref' and 'unref' callbacks in struct watchdog_driver are no longer
used and marked as deprecated.

Patch 1/5 moves watchdog device creation from watchdog_core.c to watchdog_dev.c
to simplify watchdog device handling.

Patch 2/5 separates variables in watchdog_device based on variable lifetime.

Patch 3/5 to 5/5 remove existing ref/unref functions from the drivers
implementing it.

The series applies on top of the current watchdog-next as well as the pending
patches introducing sysfs support ("watchdog: Use static struct class
watchdog_class in stead of pointer" and "watchdog: Read device status through
sysfs attributes") by Pratyush Anand.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] watchdog: Replace driver based refcounting Guenter Roeck <linux@roeck-us.net> - 2015-12-20 22:10 +0100
  [PATCH 5/5] hwmon: (sch56xx) Drop watchdog driver data reference count callbacks Guenter Roeck <linux@roeck-us.net> - 2015-12-20 22:10 +0100
    Re: [PATCH 5/5] hwmon: (sch56xx) Drop watchdog driver data reference  count callbacks Hans de Goede <hdegoede@redhat.com> - 2015-12-21 11:40 +0100
      Re: [PATCH 5/5] hwmon: (sch56xx) Drop watchdog driver data reference  count callbacks Guenter Roeck <linux@roeck-us.net> - 2015-12-21 14:30 +0100
  [PATCH 2/5] watchdog: Separate and maintain variables based on variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-20 22:10 +0100
    Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Damien Riegel <damien.riegel@savoirfairelinux.com> - 2015-12-21 18:40 +0100
      Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-22 02:20 +0100
        Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Damien Riegel <damien.riegel@savoirfairelinux.com> - 2015-12-22 17:10 +0100
          Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-22 17:30 +0100
            Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Damien Riegel <damien.riegel@savoirfairelinux.com> - 2015-12-22 20:30 +0100
              Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-22 20:40 +0100
      Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-22 02:50 +0100
        Re: [PATCH 2/5] watchdog: Separate and maintain variables based on  variable lifetime Guenter Roeck <linux@roeck-us.net> - 2015-12-23 01:40 +0100

csiph-web