Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()
Date	Tue, 22 Dec 2015 22:00:01 +0100
Message-ID	<qICch-kW-1@gated-at.bofh.it> (permalink)
References	<qI5q2-4Ow-25@gated-at.bofh.it>
X-Original-To	aryabinin@virtuozzo.com
X-Mailer	Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Dec 2015 12:58:41 -0800 (PST)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 22 Dec 2015 15:58:40 -0500 (EST)
X-Original-Message-ID	<20151222.155840.2274587303611570782.davem@davemloft.net>
X-Original-References	<1450691685-29413-1-git-send-email-aryabinin@virtuozzo.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1297061

Show key headers only | View raw

From: Andrey Ryabinin <aryabinin@virtuozzo.com>
Date: Mon, 21 Dec 2015 12:54:45 +0300

> ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded,
> ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed,
> ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer.
> 
> Fix this by inverting ip6addrlbl_hold() check.
> 
> Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.")
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ipv6/addrlabel: fix ip6addrlbl_get() Andrey Ryabinin <aryabinin@virtuozzo.com> - 2015-12-21 11:00 +0100
  Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get() Cong Wang <cwang@twopensource.com> - 2015-12-21 20:40 +0100
    Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get() YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com> - 2015-12-22 09:10 +0100
  Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get() David Miller <davem@davemloft.net> - 2015-12-22 22:00 +0100

csiph-web