Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1296170

Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

From Cong Wang <cwang@twopensource.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()
Date 2015-12-21 20:40 +0100
Message-ID <qIetj-2e0-1@gated-at.bofh.it> (permalink)
References <qI5q2-4Ow-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Dec 21, 2015 at 1:54 AM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
> ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded,
> ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed,
> ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer.
>
> Fix this by inverting ip6addrlbl_hold() check.
>
> Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.")
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>

Good catch!

Reviewed-by: Cong Wang <cwang@twopensource.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ipv6/addrlabel: fix ip6addrlbl_get() Andrey Ryabinin <aryabinin@virtuozzo.com> - 2015-12-21 11:00 +0100
  Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get() Cong Wang <cwang@twopensource.com> - 2015-12-21 20:40 +0100
    Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get() YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com> - 2015-12-22 09:10 +0100
  Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get() David Miller <davem@davemloft.net> - 2015-12-22 22:00 +0100

csiph-web