Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion
Date	Thu, 10 Dec 2015 18:40:01 +0100
Message-ID	<qEdm9-OR-3@gated-at.bofh.it> (permalink)
References	<qvVcJ-1sl-7@gated-at.bofh.it> <qvVcJ-1sl-5@gated-at.bofh.it> <qD6PM-6WV-13@gated-at.bofh.it> <qDb35-14n-31@gated-at.bofh.it> <qEbkm-7Z2-45@gated-at.bofh.it>
X-Original-To	Tomi Valkeinen <tomi.valkeinen@ti.com>
X-Me-Helo	belgarion
X-Me-Auth	amFyem1pay5yb2JlcnRAb3JhbmdlLmZy
X-Me-Date	Thu, 10 Dec 2015 18:34:57 +0100
X-Me-IP	92.156.1.80
X-URL	http://belgarath.falguerolles.org/
User-Agent	Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux)
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh+dt@kernel.org>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, <linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 10 Dec 2015 18:34:56 +0100
X-Original-Message-ID	<874mfqjjgf.fsf@belgarion.home>
X-Original-References	<1447792337-13876-1-git-send-email-robert.jarzmik@free.fr> <1447792337-13876-2-git-send-email-robert.jarzmik@free.fr> <5665B3C1.1080005@ti.com> <87bna2kmp7.fsf@belgarion.home> <56699A57.9030209@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1288715

Show key headers only | View raw

Tomi Valkeinen <tomi.valkeinen@ti.com> writes:

> On 07/12/15 22:50, Robert Jarzmik wrote:
>
>>> It seems that at least "depth" is missing from the binding document.
>> You're right.
>> 
>> Actually depth is not a "hardware" caracteristic. Moreover it's just used as an
>> overlay for pxafb_set_pixfmt() to superseed var->bits_per_pixel. I'm wondering
>> if the right path for of_get_pxafb_mode_info() would be to remove completely
>> depth, and leave it initialized at 0 for the DT case.
>> 
>> What do you think of this approach ? The other one would be to modify the
>> binding, and yet I feel this depth doesn't belong to the binding, it's my patch
>> which requires another spin IMHO.
>
> Yes, we should avoid non-hardware relate properties in the .dts files if
> at all possible. If the driver works fine without the property, I think
> it's fine to remove it. If it is required it needs to be added to the
> binding document.

Ok, agreed Tomi. That commits me for a v6, as the driver works fine on my
tests. I'll send it in the next couple of days.

Thanks for the review.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-12-07 17:30 +0100
  Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-07 22:00 +0100
    Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-12-10 16:30 +0100
      Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-10 18:40 +0100

csiph-web