Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion

From	Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion
Date	2015-12-10 16:30 +0100
Message-ID	<qEbkm-7Z2-45@gated-at.bofh.it> (permalink)
References	<qvVcJ-1sl-7@gated-at.bofh.it> <qvVcJ-1sl-5@gated-at.bofh.it> <qD6PM-6WV-13@gated-at.bofh.it> <qDb35-14n-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 07/12/15 22:50, Robert Jarzmik wrote:

>> It seems that at least "depth" is missing from the binding document.
> You're right.
> 
> Actually depth is not a "hardware" caracteristic. Moreover it's just used as an
> overlay for pxafb_set_pixfmt() to superseed var->bits_per_pixel. I'm wondering
> if the right path for of_get_pxafb_mode_info() would be to remove completely
> depth, and leave it initialized at 0 for the DT case.
> 
> What do you think of this approach ? The other one would be to modify the
> binding, and yet I feel this depth doesn't belong to the binding, it's my patch
> which requires another spin IMHO.

Yes, we should avoid non-hardware relate properties in the .dts files if
at all possible. If the driver works fine without the property, I think
it's fine to remove it. If it is required it needs to be added to the
binding document.

 Tomi

Thread

Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-12-07 17:30 +0100
  Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-07 22:00 +0100
    Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-12-10 16:30 +0100
      Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-10 18:40 +0100

csiph-web