Re: [PATCH 4/4] gpio: pxa: add pin control gpio direction and request

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] gpio: pxa: add pin control gpio direction and request
Date	2015-12-10 18:40 +0100
Message-ID	<qEdm9-OR-5@gated-at.bofh.it> (permalink)
References	<qzVxw-5SR-5@gated-at.bofh.it> <qzVxx-5SR-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> +static int pxa_gpio_request(struct gpio_chip *chip, unsigned int offset)
> +{
> +	return pinctrl_request_gpio(chip->base + offset);
> +}
> +
> +static void pxa_gpio_free(struct gpio_chip *chip, unsigned int offset)
> +{
> +	pinctrl_free_gpio(chip->base + offset);
> +}

This part will need a bit of rework : in the case of a platform data board,
pinctrl_*() returns -EPROBE_DEFER, preventing any gpio user to claim a gpio.

Either I hold with this patch to see how pxa pinctrl goes, or drop it, but in
any case this one is not ready yet for merge.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 4/4] gpio: pxa: add pin control gpio direction and request Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-10 18:40 +0100

csiph-web