Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1288786

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

Show all headers | View raw

>>>>> "Rasmus" == Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:

Rasmus> If char is signed and one of these bytes happen to have a value
Rasmus> outside the ascii range, the corresponding output will consist
Rasmus> of "ffffff" followed by the two hex chars that were actually
Rasmus> intended. One way to fix it would be to change the casts to
Rasmus> (u8*) aka (unsigned char*), but it is much simpler (and
Rasmus> generates smaller code) to use the %ph extension which was
Rasmus> created for such short hexdumps.

Applied to 4.5/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [SCSI] osd: fix signed char versus %02x issue Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-12-08 15:30 +0100
  Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue Boaz Harrosh <ooo@electrozaur.com> - 2015-12-08 23:30 +0100
  Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-12-10 19:20 +0100
    Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-10 20:20 +0100
      Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-12-10 20:20 +0100
        Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue Joe Perches <joe@perches.com> - 2015-12-10 20:30 +0100

csiph-web