Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286522

[PATCH] [SCSI] osd: fix signed char versus %02x issue

Show all headers | View raw

If char is signed and one of these bytes happen to have a value
outside the ascii range, the corresponding output will consist of
"ffffff" followed by the two hex chars that were actually
intended. One way to fix it would be to change the casts to (u8*) aka
(unsigned char*), but it is much simpler (and generates smaller code)
to use the %ph extension which was created for such short hexdumps.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 drivers/scsi/osd/osd_initiator.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
index 0cccd6033feb..d8a2b5185f56 100644
--- a/drivers/scsi/osd/osd_initiator.c
+++ b/drivers/scsi/osd/osd_initiator.c
@@ -170,10 +170,7 @@ static int _osd_get_print_system_info(struct osd_dev *od,
 
 	/* FIXME: Where are the time utilities */
 	pFirst = get_attrs[a++].val_ptr;
-	OSD_INFO("CLOCK                  [0x%02x%02x%02x%02x%02x%02x]\n",
-		((char *)pFirst)[0], ((char *)pFirst)[1],
-		((char *)pFirst)[2], ((char *)pFirst)[3],
-		((char *)pFirst)[4], ((char *)pFirst)[5]);
+	OSD_INFO("CLOCK                  [0x%6phN]\n", pFirst);
 
 	if (a < nelem) { /* IBM-OSD-SIM bug, Might not have it */
 		unsigned len = get_attrs[a].len;
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] [SCSI] osd: fix signed char versus %02x issue Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-12-08 15:30 +0100
  Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue Boaz Harrosh <ooo@electrozaur.com> - 2015-12-08 23:30 +0100
  Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-12-10 19:20 +0100
    Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-10 20:20 +0100
      Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-12-10 20:20 +0100
        Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue Joe Perches <joe@perches.com> - 2015-12-10 20:30 +0100

csiph-web