Re: [PATCH 4/7] sched: Account rr and fifo tasks separately

Path	csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!news.albasani.net!tahina.priv.at!bofh.it!news.nic.it!robomod
From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/7] sched: Account rr and fifo tasks separately
Date	Wed, 02 Dec 2015 14:00:03 +0100
Message-ID	<qBfaP-7ik-35@gated-at.bofh.it> (permalink)
References	<qunwt-7y6-9@gated-at.bofh.it> <qunwu-7y6-17@gated-at.bofh.it>
X-Original-To	Frederic Weisbecker <fweisbec@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.22.1 (2013-10-16)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Chris Metcalf <cmetcalf@ezchip.com>, Thomas Gleixner <tglx@linutronix.de>, Luiz Capitulino <lcapitulino@redhat.com>, Christoph Lameter <cl@linux.com>, Ingo Molnar <mingo@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, Rik van Riel <riel@redhat.com>
X-Original-Date	Wed, 2 Dec 2015 13:53:39 +0100
X-Original-Message-ID	<20151202125339.GE9928@worktop.ger.corp.intel.com>
X-Original-References	<1447424529-13671-1-git-send-email-fweisbec@gmail.com> <1447424529-13671-5-git-send-email-fweisbec@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1281761

Show key headers only | View raw

On Fri, Nov 13, 2015 at 03:22:06PM +0100, Frederic Weisbecker wrote:
> In order to evaluate tick dependency, we need to account SCHED_RR and
> SCHED_FIFO tasks separately as those policies don't have the same
> preemption requirements.
> 
> We still keep rt_nr_running as a cache to avoid additions between nr_rr
> and nr_fifo all over the place.

In which case you only need one of nr_fifo/nr_rr. Less accounting is
better.

Pick the one you need for the nohz_full condition, and leave the other.
A quick look at sched_can_stop_tick() seems to suggest nr_rr is the
interesting one. nr_rr < 2 should allow stopping the tick.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/7] sched: Account rr and fifo tasks separately Peter Zijlstra <peterz@infradead.org> - 2015-12-02 14:00 +0100
  Re: [PATCH 4/7] sched: Account rr and fifo tasks separately Frederic Weisbecker <fweisbec@gmail.com> - 2015-12-02 15:20 +0100

csiph-web