Re: [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach (v2)

From	Mike Galbraith <umgwanakikbuti@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach (v2)
Date	2015-12-02 07:30 +0100
Message-ID	<qB95o-3ur-5@gated-at.bofh.it> (permalink)
References	<qyQqe-3L8-17@gated-at.bofh.it> <qz3x8-4VN-9@gated-at.bofh.it> <qzdmO-2Nc-25@gated-at.bofh.it> <qAWhP-3F3-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2015-12-01 at 11:49 -0500, Tejun Heo wrote:
> On Thu, Nov 26, 2015 at 08:32:32PM -0200, Marcelo Tosatti wrote:
> > 
> > Move PF_NO_SETAFFINITY and kthreadd_task checks to cpuset cgroups,  
> > where they belong. This makes it possible to attach PF_NO_SETAFFINITY 
> > tasks to Intel CAT cgroup.
> > 
> > Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > Reviewed-by: Chao Peng <chao.p.peng@linux.intel.com>
> > 
> > v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task
> > checks"
> 
> This wasn't just for cpuset.  It's for all controllers.

Hm, indeed.  Workers landing in a throttled cfs rq wouldn't be as
painful as an rt worker being born in an rq with no rt_runtime, but
could sting.  Workers stuffed into the freezer would sting mightily.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] cgroups: move cpuset specific checks from generic code  to cpuset_can_attach (v2) Tejun Heo <tj@kernel.org> - 2015-12-01 17:50 +0100
  Re: [PATCH] cgroups: move cpuset specific checks from generic code  to cpuset_can_attach (v2) Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-12-02 07:30 +0100

csiph-web