Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1281036 > unrolled thread

Re: [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach (v2)

Started byTejun Heo <tj@kernel.org>
First post2015-12-01 17:50 +0100
Last post2015-12-02 07:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] cgroups: move cpuset specific checks from generic code  to cpuset_can_attach (v2) Tejun Heo <tj@kernel.org> - 2015-12-01 17:50 +0100
    Re: [PATCH] cgroups: move cpuset specific checks from generic code  to cpuset_can_attach (v2) Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-12-02 07:30 +0100

#1281036 — Re: [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach (v2)

FromTejun Heo <tj@kernel.org>
Date2015-12-01 17:50 +0100
SubjectRe: [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach (v2)
Message-ID<qAWhP-3F3-11@gated-at.bofh.it>
On Thu, Nov 26, 2015 at 08:32:32PM -0200, Marcelo Tosatti wrote:
> 
> Move PF_NO_SETAFFINITY and kthreadd_task checks to cpuset cgroups,  
> where they belong. This makes it possible to attach PF_NO_SETAFFINITY 
> tasks to Intel CAT cgroup.
> 
> Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> Reviewed-by: Chao Peng <chao.p.peng@linux.intel.com>
> 
> v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task
> checks"

This wasn't just for cpuset.  It's for all controllers.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1281485

FromMike Galbraith <umgwanakikbuti@gmail.com>
Date2015-12-02 07:30 +0100
Message-ID<qB95o-3ur-5@gated-at.bofh.it>
In reply to#1281036
On Tue, 2015-12-01 at 11:49 -0500, Tejun Heo wrote:
> On Thu, Nov 26, 2015 at 08:32:32PM -0200, Marcelo Tosatti wrote:
> > 
> > Move PF_NO_SETAFFINITY and kthreadd_task checks to cpuset cgroups,  
> > where they belong. This makes it possible to attach PF_NO_SETAFFINITY 
> > tasks to Intel CAT cgroup.
> > 
> > Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > Reviewed-by: Chao Peng <chao.p.peng@linux.intel.com>
> > 
> > v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task
> > checks"
> 
> This wasn't just for cpuset.  It's for all controllers.

Hm, indeed.  Workers landing in a throttled cfs rq wouldn't be as
painful as an rt worker being born in an rq with no rt_runtime, but
could sting.  Workers stuffed into the freezer would sting mightily.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web