Re: [PATCH 1/2] regulator: Add regmap support to regulator-fixed device tree binding

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] regulator: Add regmap support to regulator-fixed device tree binding
Date	2015-11-30 13:20 +0100
Message-ID	<qAvB0-3vl-5@gated-at.bofh.it> (permalink)
References	<qzV4t-5Ew-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, Nov 28, 2015 at 09:13:01PM +0000, Simon Arlott wrote:
> Add properties for regmap to the regulator-fixed device tree binding:
> * Reference the regmap phandle
> * Specify the enable offset and enable mask
> * Reuse enable-active-high for regmap
> 
> This is required for Broadcom BCM63xx SoCs that enable power to
> individual peripherals by clearing a bit in the miscIddqCtrl register.

Just write a driver for this, the fixed driver is really intended for
things like discrete regulators and if we were going to do a generic
regmap driver (which I'm not terribly keen on as it means we're not able
to later add additional information or custom handling in the driver) we
should just do that rather than shoehorning things into the fixed driver.

Thread

[PATCH 1/2] regulator: Add regmap support to regulator-fixed device  tree binding Simon Arlott <simon@fire.lp0.eu> - 2015-11-28 22:20 +0100
  Re: [PATCH 1/2] regulator: Add regmap support to regulator-fixed  device tree binding Mark Brown <broonie@kernel.org> - 2015-11-30 13:20 +0100
    [PATCH (v2) 2/2] regulator: bcm63xx: Add BCM63xx fixed regulator  device Simon Arlott <simon@fire.lp0.eu> - 2015-11-30 21:40 +0100
      Re: [PATCH (v2) 2/2] regulator: bcm63xx: Add BCM63xx fixed regulator  device Mark Brown <broonie@kernel.org> - 2015-12-01 16:20 +0100
    [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree binding Simon Arlott <simon@fire.lp0.eu> - 2015-11-30 21:40 +0100
      [PATCH 2/2] regulator: bcm63xx: Add BCM63xx fixed regulator device Simon Arlott <simon@fire.lp0.eu> - 2015-11-30 21:40 +0100
      Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-01 23:20 +0100
        Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding "Simon Arlott" <simon@fire.lp0.eu> - 2015-12-02 13:50 +0100
          Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-02 14:00 +0100
            Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Simon Arlott <simon@fire.lp0.eu> - 2015-12-02 21:30 +0100
              Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-03 01:10 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Simon Arlott <simon@fire.lp0.eu> - 2015-12-03 09:20 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-03 16:10 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Simon Arlott <simon@fire.lp0.eu> - 2015-12-04 00:40 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-04 00:50 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Simon Arlott <simon@fire.lp0.eu> - 2015-12-04 01:00 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-04 12:10 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding "Simon Arlott" <simon@fire.lp0.eu> - 2015-12-04 13:30 +0100
                Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree  binding Mark Brown <broonie@kernel.org> - 2015-12-05 18:00 +0100

csiph-web