Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1279819

Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical addresses from non-privileged users

From Willy Tarreau <w@1wt.eu>
Newsgroups linux.kernel
Subject Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical addresses from non-privileged users
Date 2015-11-30 13:20 +0100
Message-ID <qAvB0-3vl-1@gated-at.bofh.it> (permalink)
References <qAikq-3oq-27@gated-at.bofh.it> <qAlV0-5pM-11@gated-at.bofh.it> <qAqKZ-qe-3@gated-at.bofh.it> <qAuYh-2X2-1@gated-at.bofh.it> <qAvhH-38r-73@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 30, 2015 at 02:49:59PM +0300, Konstantin Khlebnikov wrote:
> On 30.11.2015 14:30, Willy Tarreau wrote:
> >+	/* do not disclose physical addresses: attack vector */
> >+	pm.show_pfn = !cap_capable(current, file->f_cred, CAP_SYS_ADMIN, 
> >SECURITY_CAP_AUDIT);
> >+
> 
> At first sight this is confusing... but correct. It really returns zero
> for success, unlike to new file_ns_capable which returns bool true.

Yes, it trapped me as well, the first attempt I made only allowed non-root
to read the pagemap!

> The rest looks good too.

OK thank you.

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical addresses from non-privileged  users Willy Tarreau <w@1wt.eu> - 2015-11-29 23:10 +0100
  Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical  addresses from non-privileged users Ben Hutchings <ben@decadent.org.uk> - 2015-11-30 03:00 +0100
    Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical addresses from non-privileged users Willy Tarreau <w@1wt.eu> - 2015-11-30 08:10 +0100
      Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical addresses from non-privileged users Willy Tarreau <w@1wt.eu> - 2015-11-30 12:40 +0100
        Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical  addresses from non-privileged users Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-11-30 13:00 +0100
          Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical addresses from non-privileged users Willy Tarreau <w@1wt.eu> - 2015-11-30 13:20 +0100
        Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical  addresses from non-privileged users Ben Hutchings <ben@decadent.org.uk> - 2015-11-30 16:00 +0100
          Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical addresses from non-privileged users Willy Tarreau <w@1wt.eu> - 2015-11-30 16:20 +0100

csiph-web