Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281151

Re: [PATCH] regulator: core: Ensure we lock all regulators

Show all headers | View raw

On Tuesday 01 December 2015 16:53:01 Mark Brown wrote:
> On Tue, Dec 01, 2015 at 05:45:17PM +0100, Arnd Bergmann wrote:
> > On Tuesday 01 December 2015 16:40:57 Mark Brown wrote:
> 
> > >         mutex_lock(&rdev->mutex);
> > > -       for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++)
> > > +       for (i = 1; rdev; rdev = rdev->supply->rdev, i++)
> > >                 mutex_lock_nested(&rdev->mutex, i);
> 
> > I think now we have a double lock, the initial mutex_lock() needs to
> > be removed again.
> 
> Ugh, I even made that fix before I sent but didn't actually commit it
>

I'm glad I'm not the only one who can screw up a trivial one-line
fix to this damned function. ;-)

I'm still leading with three stupid mistakes over your one though.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] regulator: core: Ensure we lock all regulators Arnd Bergmann <arnd@arndb.de> - 2015-12-01 17:50 +0100
  Re: [PATCH] regulator: core: Ensure we lock all regulators Mark Brown <broonie@kernel.org> - 2015-12-01 18:00 +0100
    Re: [PATCH] regulator: core: Ensure we lock all regulators Arnd Bergmann <arnd@arndb.de> - 2015-12-01 20:40 +0100
      Re: [PATCH] regulator: core: Ensure we lock all regulators Mark Brown <broonie@kernel.org> - 2015-12-01 20:50 +0100

csiph-web