Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1281043
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] regulator: core: Ensure we lock all regulators |
| Date | 2015-12-01 18:00 +0100 |
| Message-ID | <qAWrw-3Jy-7@gated-at.bofh.it> (permalink) |
| References | <qAWhQ-3F3-25@gated-at.bofh.it> <qAWhQ-3F3-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Dec 01, 2015 at 05:45:17PM +0100, Arnd Bergmann wrote: > On Tuesday 01 December 2015 16:40:57 Mark Brown wrote: > > mutex_lock(&rdev->mutex); > > - for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++) > > + for (i = 1; rdev; rdev = rdev->supply->rdev, i++) > > mutex_lock_nested(&rdev->mutex, i); > I think now we have a double lock, the initial mutex_lock() needs to > be removed again. Ugh, I even made that fix before I sent but didn't actually commit it :(
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] regulator: core: Ensure we lock all regulators Arnd Bergmann <arnd@arndb.de> - 2015-12-01 17:50 +0100
Re: [PATCH] regulator: core: Ensure we lock all regulators Mark Brown <broonie@kernel.org> - 2015-12-01 18:00 +0100
Re: [PATCH] regulator: core: Ensure we lock all regulators Arnd Bergmann <arnd@arndb.de> - 2015-12-01 20:40 +0100
Re: [PATCH] regulator: core: Ensure we lock all regulators Mark Brown <broonie@kernel.org> - 2015-12-01 20:50 +0100
csiph-web