Re: [PATCH] regulator: core: Ensure we lock all regulators

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: core: Ensure we lock all regulators
Date	2015-12-01 17:50 +0100
Message-ID	<qAWhQ-3F3-23@gated-at.bofh.it> (permalink)
References	<qAWhQ-3F3-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 01 December 2015 16:40:57 Mark Brown wrote:
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index daffff83ced2..f71db02fcb71 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -141,7 +141,7 @@ static void regulator_lock_supply(struct regulator_dev *rdev)
>         int i;
>  
>         mutex_lock(&rdev->mutex);
> -       for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++)
> +       for (i = 1; rdev; rdev = rdev->supply->rdev, i++)
>                 mutex_lock_nested(&rdev->mutex, i);
> 

I think now we have a double lock, the initial mutex_lock() needs to
be removed again.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] regulator: core: Ensure we lock all regulators Arnd Bergmann <arnd@arndb.de> - 2015-12-01 17:50 +0100
  Re: [PATCH] regulator: core: Ensure we lock all regulators Mark Brown <broonie@kernel.org> - 2015-12-01 18:00 +0100
    Re: [PATCH] regulator: core: Ensure we lock all regulators Arnd Bergmann <arnd@arndb.de> - 2015-12-01 20:40 +0100
      Re: [PATCH] regulator: core: Ensure we lock all regulators Mark Brown <broonie@kernel.org> - 2015-12-01 20:50 +0100

csiph-web