Re: [PATCH 1/4 v2] mtd: brcmnand: improve memory management

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4 v2] mtd: brcmnand: improve memory management
Date	2015-12-01 03:00 +0100
Message-ID	<qAIox-360-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <qwjf5-Ju-21@gated-at.bofh.it> <qwjI6-Vr-17@gated-at.bofh.it> <qwqJz-5C5-3@gated-at.bofh.it> <qwD46-5aJ-3@gated-at.bofh.it> <qwF5U-6t3-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 19, 2015 at 10:32:15PM +0100, Julia Lawall wrote:
> This patch addresses two related memory management issues in the probe
> function:
> 
> 1. for_each_available_child_of_node performs an of_node_get on each
> iteration, so a break out of the loop requires an of_node_put.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
> 
>  for_each_available_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> 2. The devm_kzalloc'd data is not used if brcmnand_init_cs fails.  Free it
> immediately, using devm_kfree in this case, instead of waiting for the
> remove function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
> 
> v2: Drop of_node_get addition, as another patch will get rid of the need
> for it completely.

Pushed to l2-mtd.git
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-11-18 23:20 +0100
  [PATCH 1/4] mtd: brcmnand: improve memory management Julia Lawall <Julia.Lawall@lip6.fr> - 2015-11-18 23:20 +0100
    Re: [PATCH 1/4] mtd: brcmnand: improve memory management Brian Norris <computersforpeace@gmail.com> - 2015-11-18 23:50 +0100
      Re: [PATCH 1/4] mtd: brcmnand: improve memory management Julia Lawall <julia.lawall@lip6.fr> - 2015-11-19 07:20 +0100
        Re: [PATCH 1/4] mtd: brcmnand: improve memory management Brian Norris <computersforpeace@gmail.com> - 2015-11-19 20:30 +0100
          [PATCH 1/4 v2] mtd: brcmnand: improve memory management Julia Lawall <julia.lawall@lip6.fr> - 2015-11-19 22:40 +0100
            Re: [PATCH 1/4 v2] mtd: brcmnand: improve memory management Brian Norris <computersforpeace@gmail.com> - 2015-12-01 03:00 +0100

csiph-web