Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280481

Re: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put

Show all headers | View raw

On Wed, Nov 18, 2015 at 11:04:12PM +0100, Julia Lawall wrote:
> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 

Pushed to l2-mtd.git
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] mtd: nand: sunxi: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-11-18 23:20 +0100
  Re: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put Chen-Yu Tsai <wens@csie.org> - 2015-11-23 08:30 +0100
  Re: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-23 15:00 +0100
  Re: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put Brian Norris <computersforpeace@gmail.com> - 2015-12-01 03:00 +0100

csiph-web