Re: [PATCH 1/4] mtd: brcmnand: improve memory management

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] mtd: brcmnand: improve memory management
Date	2015-11-19 20:30 +0100
Message-ID	<qwD46-5aJ-3@gated-at.bofh.it> (permalink)
References	<qwjf4-Ju-5@gated-at.bofh.it> <qwjf5-Ju-21@gated-at.bofh.it> <qwjI6-Vr-17@gated-at.bofh.it> <qwqJz-5C5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 19, 2015 at 07:13:45AM +0100, Julia Lawall wrote:
> On Wed, 18 Nov 2015, Brian Norris wrote:
> > On Wed, Nov 18, 2015 at 11:04:11PM +0100, Julia Lawall wrote:
> > > 3. If the continue is not taken, then host is added to a list, that has a
> > > lifetime beyond the end of the for_each_available_child_of_node loop body.
> > > Thus, of_node_get is needed on child, which is referenced by host.  A
> > > corresponding of_node_put is needed in the remove function.
> > 
> > This one's a bit silly. We really shouldn't be keeping the reference in
> > 'host' at all. Also, as of commit 215a02fd3087 ("mtd: grab a reference to
> > the MTD of_node before registering it"), the MTD core will actually be
> > refcounting the node for us, too, so this isn't really necessary.
> > 
> > I have a patch to remove brcmnand_host::of_node (appended below), which
> > should make this step obsolete, and be more obvious that no extra
> > of_node_get()'ing is required.
> 
> OK.  Should I resend my patch without this change?

Sure, that'd be good. Then I could merge/rebase mine on top.

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/4] add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-11-18 23:20 +0100
  [PATCH 1/4] mtd: brcmnand: improve memory management Julia Lawall <Julia.Lawall@lip6.fr> - 2015-11-18 23:20 +0100
    Re: [PATCH 1/4] mtd: brcmnand: improve memory management Brian Norris <computersforpeace@gmail.com> - 2015-11-18 23:50 +0100
      Re: [PATCH 1/4] mtd: brcmnand: improve memory management Julia Lawall <julia.lawall@lip6.fr> - 2015-11-19 07:20 +0100
        Re: [PATCH 1/4] mtd: brcmnand: improve memory management Brian Norris <computersforpeace@gmail.com> - 2015-11-19 20:30 +0100
          [PATCH 1/4 v2] mtd: brcmnand: improve memory management Julia Lawall <julia.lawall@lip6.fr> - 2015-11-19 22:40 +0100

csiph-web