Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1280260

Re: [PATCH] mtd: cfi: enforce valid geometry configuration

From Brian Norris <computersforpeace@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mtd: cfi: enforce valid geometry configuration
Date 2015-11-30 21:50 +0100
Message-ID <qADyy-8ry-13@gated-at.bofh.it> (permalink)
References <qxZFh-2qN-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Nov 23, 2015 at 02:39:33PM +0100, Arnd Bergmann wrote:
> MTD allows compile-time configuration of the possible CFI geometry
> settings that are allowed by the kernel, but that includes a couple of
> invalid configurations, where no bank width or no interleave setting
> is allowed. These are then caught with a compile-time warning:
> 
> include/linux/mtd/cfi.h:76:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
> include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
> 
> This is a bit annoying for randconfig tests, and can be avoided if
> we change the Kconfig logic to always select the simplest configuration
> when no other one is enabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Pushed to l2-mtd.git. Thanks for fixing this one! I guess an ugly fix is
better than nothing here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] mtd: cfi: enforce valid geometry configuration Arnd Bergmann <arnd@arndb.de> - 2015-11-23 14:50 +0100
  Re: [PATCH] mtd: cfi: enforce valid geometry configuration Arnd Bergmann <arnd@arndb.de> - 2015-11-23 23:20 +0100
    [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD Arnd Bergmann <arnd@arndb.de> - 2015-11-24 23:20 +0100
      Re: [PATCH] mtd: cfi: don't warn about broken geometry for  !CONFIG_MTD Brian Norris <computersforpeace@gmail.com> - 2015-11-30 22:00 +0100
        Re: [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD Arnd Bergmann <arnd@arndb.de> - 2015-11-30 22:50 +0100
  Re: [PATCH] mtd: cfi: enforce valid geometry configuration Brian Norris <computersforpeace@gmail.com> - 2015-11-30 21:50 +0100

csiph-web