Re: [PATCH 1/3] usb: musb: convert printk to pr_*

From	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] usb: musb: convert printk to pr_*
Date	2015-11-30 21:50 +0100
Message-ID	<qADyy-8ry-1@gated-at.bofh.it> (permalink)
References	<qzoBz-1DT-13@gated-at.bofh.it> <qzqk1-2Nt-1@gated-at.bofh.it> <qzBfr-1jj-17@gated-at.bofh.it> <qzKVr-7AO-9@gated-at.bofh.it>
Organization	D03

Show all headers | View raw

On Sat, Nov 28 2015, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:

> On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote:
>
>>>> This file already uses pr_debug in a few places; this converts the
>>>> remaining printks.
>>>
>>>     Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent?
>>
>> Yes, and that is a good thing, you should be using pr_debug() instead of
>> printk(KERN_DEBUG...).
>>
>> Why object to something like this?
>
>    I'm not objecting, just asking. There have been many cases in my
> practice where a patch author wasn't aware of that...

I was aware, but I can see how the commit message could indicate
otherwise. I don't feel strongly for the conversion, so I could redo 2/3
and 3/3 (which should be uncontroversial cleanups).

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] usb: musb: convert printk to pr_* Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-27 11:40 +0100
  [PATCH 3/3] usb: musb: remove redundant stack buffer Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-27 11:40 +0100
    Re: [PATCH 3/3] usb: musb: remove redundant stack buffer Felipe Balbi <balbi@ti.com> - 2015-12-01 16:10 +0100
      Re: [PATCH 3/3] usb: musb: remove redundant stack buffer Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-12-03 10:40 +0100
  [PATCH 2/3] usb: musb: remove always-empty string from debug output Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-27 11:40 +0100
  Re: [PATCH 1/3] usb: musb: convert printk to pr_* Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-27 13:30 +0100
    Re: [PATCH 1/3] usb: musb: convert printk to pr_* Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-28 01:10 +0100
      Re: [PATCH 1/3] usb: musb: convert printk to pr_* Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-28 11:30 +0100
        Re: [PATCH 1/3] usb: musb: convert printk to pr_* Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-30 21:50 +0100

csiph-web