Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280270

Re: [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD

Show all headers | View raw

On Tue, Nov 24, 2015 at 11:09:02PM +0100, Arnd Bergmann wrote:
> The linux/mtd/map.h header file is included by a couple of
> platform specific files that are built even when CONFIG_MTD
> is disabled, and we always get
> 
>  warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
> 
> in that case. This adds an #ifdef around the pointless warning,
> as everything is really fine when we don't build the drivers
> anyway.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> > I'm actually still getting the warnings for any file that includes <linux/mtd/map.h>
> > while CONFIG_MTD is disabled. I have a fix now that I'm testing overnight
> > and plan to post tomorrow, then we can decide whether it should be part of
> > the same patch, or we should have two separate patches.
> 
> The patch fixes the remaining warnings I see on ARM randconfigs in this file,
> and I think it makes sense to keep it as a separate patch, as these are really
> distinct problems even thought the symptom is the same.
> 
> Please apply both.
> 
> diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h
> index 366cf77953b5..58f3ba709ade 100644
> --- a/include/linux/mtd/map.h
> +++ b/include/linux/mtd/map.h
> @@ -142,7 +142,9 @@
>  #endif
>  
>  #ifndef map_bankwidth
> +#ifdef CONFIG_MTD
>  #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
> +#endif
>  static inline int map_bankwidth(void *map)
>  {
>  	BUG();
> 

I guess no one includes mtd/cfi.h with CONFIG_MTD=n? Otherwise, we might
have the same problems there.

Pushed to l2-mtd.git, thanks!

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: cfi: enforce valid geometry configuration Arnd Bergmann <arnd@arndb.de> - 2015-11-23 14:50 +0100
  Re: [PATCH] mtd: cfi: enforce valid geometry configuration Arnd Bergmann <arnd@arndb.de> - 2015-11-23 23:20 +0100
    [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD Arnd Bergmann <arnd@arndb.de> - 2015-11-24 23:20 +0100
      Re: [PATCH] mtd: cfi: don't warn about broken geometry for  !CONFIG_MTD Brian Norris <computersforpeace@gmail.com> - 2015-11-30 22:00 +0100
        Re: [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD Arnd Bergmann <arnd@arndb.de> - 2015-11-30 22:50 +0100
  Re: [PATCH] mtd: cfi: enforce valid geometry configuration Brian Norris <computersforpeace@gmail.com> - 2015-11-30 21:50 +0100

csiph-web