Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1226598

[PATCH 1/2] virtio: fix memory leak of virtio ida cache layers

Show all headers | View raw

The virtio core uses a static ida named virtio_index_ida for
assigning index numbers to virtio devices during registration.
The ida core may allocate some internal idr cache layers and
an ida bitmap upon any ida allocation, and all these layers are
truely freed only upon the ida destruction. The virtio_index_ida
is not destroyed at present, leading to a memory leak when using
the virtio core as a module and atleast one virtio device is
registered and unregistered.

Fix this by invoking ida_destroy() in the virtio core module
exit.

Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
---
 drivers/virtio/virtio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index b1877d73fa56..7062bb0975a5 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -412,6 +412,7 @@ static int virtio_init(void)
 static void __exit virtio_exit(void)
 {
 	bus_unregister(&virtio_bus);
+	ida_destroy(&virtio_index_ida);
 }
 core_initcall(virtio_init);
 module_exit(virtio_exit);
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Fix memory leaks in virtio & remoteproc cores Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
  [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
  [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
    DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-17 07:40 +0200
      Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) Hannes Reinecke <hare@suse.de> - 2015-09-17 09:00 +0200
        Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) Suman Anna <s-anna@ti.com> - 2015-09-18 00:40 +0200
      Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 16:20 +0200
        Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 17:20 +0200
        Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-17 18:10 +0200
          Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 18:50 +0200
            Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 19:20 +0200
              Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 20:00 +0200
                Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 20:10 +0200

csiph-web