[PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers

From	Suman Anna <s-anna@ti.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers
Date	2015-09-17 02:30 +0200
Message-ID	<q9vfk-3Em-13@gated-at.bofh.it> (permalink)
References	<q9vfk-3Em-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The remoteproc core uses a static ida named rproc_dev_index for
assigning an automatic index number to a registered remoteproc.
The ida core may allocate some internal idr cache layers and ida
bitmap upon any ida allocation, and all these layers are truely
freed only upon the ida destruction. The rproc_dev_index ida is
not destroyed at present, leading to a memory leak when using the
remoteproc core as a module and atleast one rproc device is
registered and unregistered.

Fix this by invoking ida_destroy() in the remoteproc core module
exit.

Cc: Ohad Ben-Cohen <ohad@wizery.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
---
 drivers/remoteproc/remoteproc_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 8b3130f22b42..9e03d158f411 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1478,6 +1478,8 @@ module_init(remoteproc_init);
 
 static void __exit remoteproc_exit(void)
 {
+	ida_destroy(&rproc_dev_index);
+
 	rproc_exit_debugfs();
 }
 module_exit(remoteproc_exit);
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] Fix memory leaks in virtio & remoteproc cores Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
  [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
  [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers Suman Anna <s-anna@ti.com> - 2015-09-17 02:30 +0200
    DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-17 07:40 +0200
      Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) Hannes Reinecke <hare@suse.de> - 2015-09-17 09:00 +0200
        Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix  memory leak of virtio ida cache layers) Suman Anna <s-anna@ti.com> - 2015-09-18 00:40 +0200
      Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 16:20 +0200
        Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 17:20 +0200
        Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) "Michael S. Tsirkin" <mst@redhat.com> - 2015-09-17 18:10 +0200
          Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 18:50 +0200
            Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 19:20 +0200
              Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-17 20:00 +0200
                Re: DEFINE_IDA causing memory leaks? (was  Re: [PATCH 1/2] virtio:  fix memory leak of virtio ida cache layers) Tejun Heo <htejun@gmail.com> - 2015-09-17 20:10 +0200

csiph-web